Merge pull request #397 from neutron-org/fix/exp_time_comments

Cleanup comments for expiration_time to match current naming
neutron-org · Jan 25, 2024 · 4fe3e78 · 4fe3e78
2 parents 6c65c3f + c572da4
commit 4fe3e78
Show file tree

Hide file tree

Showing 31 changed files with 1,073 additions and 1,062 deletions.
diff --git a/docs/static/openapi.yml b/docs/static/openapi.yml
diff --git a/proto/neutron/dex/limit_order_expiration.proto b/proto/neutron/dex/limit_order_expiration.proto
@@ -7,7 +7,7 @@ import "google/protobuf/timestamp.proto";
 option go_package = "github.com/neutron-org/neutron/v2/x/dex/types";
 
 message LimitOrderExpiration {
-  // see limitOrderTranche.proto for details on goodTilDate
+  // see limitOrderTranche.proto for details on expiration_time
   google.protobuf.Timestamp expiration_time = 1 [
     (gogoproto.stdtime) = true,
     (gogoproto.nullable) = false

diff --git a/proto/neutron/dex/limit_order_tranche.proto b/proto/neutron/dex/limit_order_tranche.proto
@@ -40,12 +40,11 @@ message LimitOrderTranche {
     (gogoproto.nullable) = false,
     (gogoproto.jsontag) = "total_taker_denom"
   ];
-  // expiration_time is represented as an RFC 3339 formatted date.
-  // LimitOrders with expiration_time set are valid as long as blockTime <= expiration_time.
-  // JIT orders also use expiration_time to handle deletion, but represent a special case.
-  // All JIT orders have an expiration_time of 0001-01-01T00:00:00Z, and an exception is made to
-  // still treat these orders as live. Order deletion still functions the
-  // same, and the orders will be deleted at the end of the block.
+  // LimitOrders with expiration_time set are valid as long as blockTime <= expiration_time
+
+  // JIT orders also use expiration_time to handle deletion but represent a special case
+  // All JIT orders have a expiration_time of 0 and an exception is made to still treat these orders as live
+  // Order deletion still functions the same and the orders will be deleted at the end of the block
   google.protobuf.Timestamp expiration_time = 6 [
     (gogoproto.stdtime) = true,
     (gogoproto.nullable) = true

diff --git a/x/contractmanager/types/failure.pb.go b/x/contractmanager/types/failure.pb.go
diff --git a/x/contractmanager/types/genesis.pb.go b/x/contractmanager/types/genesis.pb.go
diff --git a/x/contractmanager/types/query.pb.go b/x/contractmanager/types/query.pb.go
diff --git a/x/contractmanager/types/tx.pb.go b/x/contractmanager/types/tx.pb.go