Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: remove incorrect dex query #384

Merged
merged 4 commits into from
Apr 24, 2024
Merged

FIX: remove incorrect dex query #384

merged 4 commits into from
Apr 24, 2024

Conversation

jcompagni10
Copy link
Contributor

remove /neutron.dex.Query/UserLimitOrdersAll as it does not exist

pr0n00gler
pr0n00gler previously approved these changes Nov 29, 2023
View reviewed changes
sotnikov-s
sotnikov-s previously approved these changes Nov 30, 2023
View reviewed changes
@sotnikov-s sotnikov-s changed the base branch from update-sdk47 to main November 30, 2023 04:51
@sotnikov-s sotnikov-s dismissed stale reviews from pr0n00gler and themself November 30, 2023 04:51

The base branch was changed.

@sotnikov-s
Copy link
Contributor

update/sdk-47 has already been merged, so I redirected the PR

sotnikov-s
sotnikov-s requested changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@sotnikov-s sotnikov-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, no approve, yet: there's still inconsistency between the correct rpc and req/resp messages: LimitOrderTrancheUserAllByAddress. but still QueryAllUserLimitOrdersRequest and QueryAllUserLimitOrdersResponse

neutron/proto/neutron/dex/query.proto

Line 45 in e605ed3

rpc LimitOrderTrancheUserAllByAddress(QueryAllUserLimitOrdersRequest) returns (QueryAllUserLimitOrdersResponse) {

@jcompagni10
Copy link
Contributor Author

actually, no approve, yet: there's still inconsistency between the correct rpc and req/resp messages: LimitOrderTrancheUserAllByAddress. but still QueryAllUserLimitOrdersRequest and QueryAllUserLimitOrdersResponse

@sotnikov-s Just to clarify are you seeing an actual problem here or just saying that for clarity the RPC name should match the request and response names?

@pr0n00gler
Copy link
Collaborator

@jcompagni10 please resolve conflicts here

@jcompagni10
Copy link
Contributor Author

https://github.com/neutron-org/neutron-tests/actions/runs/7631732111

@pr0n00gler pr0n00gler marked this pull request as draft February 8, 2024 20:40
@jcompagni10 jcompagni10 changed the base branch from main to feat/sdk-50 March 19, 2024 19:50
@jcompagni10 jcompagni10 marked this pull request as ready for review March 19, 2024 19:50
@pr0n00gler pr0n00gler merged commit 312fdeb into feat/sdk-50 Apr 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pr0n00gler pr0n00gler pr0n00gler approved these changes

@sotnikov-s sotnikov-s sotnikov-s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcompagni10 @sotnikov-s @pr0n00gler