NTRN-188 refactor dex module keeper #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcompagni10
requested changes
Dec 21, 2023
x/dex/keeper/pool.go
Outdated
| return types.NewPool(pairID, centerTickIndexNormalized, fee, poolID) | ||
| } | ||
|
|
||
| func (k Keeper) initializePoolMetadata( |
There was a problem hiding this comment.
maybe move this to keeper/pool_metadata.go ?
| @@ -85,7 +118,6 @@ func (k Keeper) GetPool( | |||
| case lowerTickFound && !upperTickFound: | |||
| upperTick = types.NewPoolReservesFromCounterpart(lowerTick) | |||
| case !lowerTickFound && !upperTickFound: | |||
| // Pool has already been initialized before so we can safely assume that pool creation doesn't throw an error | |||
There was a problem hiding this comment.
Maybe just personal preference, but I like comments explaining why we chose to use a method that panics. Otherwise, it can look like a mistake to someone later.
x/dex/keeper/pool.go
Outdated
| return poolID | ||
| } | ||
|
|
||
| func (k Keeper) storePoolID( |
There was a problem hiding this comment.
Can we call this storePoolIDRef? Seems a bit more clear.
pr0n00gler
previously approved these changes
Jan 14, 2024
pr0n00gler
approved these changes
Jan 23, 2024
jcompagni10
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TASK
Get poolByID is currently inefficient.It currently makes an unnecessary call to k.GetPoolIDByParams as part of k.GetPool
This code should be refactored.
I also refactored InitPool & SetPool functions because I can