Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(x): bit of proofreading #426

Closed
wants to merge 1 commit into from
Closed

chore(x): bit of proofreading #426

wants to merge 1 commit into from

Conversation

Ursulafe
Copy link

Came across few errors, one is a plain text file, rest are comments

quasisamurai
quasisamurai suggested changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@quasisamurai quasisamurai left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, i've noticed that you edited proto-generated files manually. We're not allowing this for obvious reasons. Please, make sure to edit source proto files & run make proto-gen

@pr0n00gler
Copy link
Collaborator

#496

@pr0n00gler pr0n00gler closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quasisamurai quasisamurai quasisamurai requested changes

@swelf19 swelf19 swelf19 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ursulafe @pr0n00gler @quasisamurai @swelf19