IBC Rate Limit Changes For Neutron #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonedaddy
changed the title
bonedaddy
force-pushed
the
feat/ibc-rate-limit
branch
from
cbbe6f8 to
124320a
Compare
sotnikov-s
reviewed
Sep 11, 2024
Comment on lines
106
to
113
| let response: QuerySupplyOfResponse = deps.querier.query(&cosmwasm_std::QueryRequest::Grpc({ | ||
| GrpcQuery { | ||
| path: "/cosmos.bank.v1beta1.Query/SupplyOf".to_string(), | ||
| data: Binary::from_base64( | ||
| &to_base64(self.local_denom(direction)) | ||
| )? | ||
| } | ||
| }))?; |
There was a problem hiding this comment.
I think we can reuse the grpc query helpers here just as it is done here https://github.com/neutron-org/neutron-dev-contracts/blob/2589bbdda4496608626d457902d548e36134945a/contracts/grpc_querier/src/contract.rs#L68
There was a problem hiding this comment.
Makes sense and that would simplify the function a lot, should I remove and change to
pub fn channel_value(&self, deps: Deps, direction: &FlowType) -> Result<Uint256, StdError> {
Ok(Uint256::from_uint128(deps.querier.query_supply(self.local_denom(direction))?.amount))
}
sotnikov-s
approved these changes
Sep 13, 2024
pr0n00gler
approved these changes
Sep 13, 2024
pr0n00gler
merged commit 0c0dffb
into
neutron-org:feat/ibc-rate-limit
5 of 8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds changes needed to make the osmosis ibc rate limit contract compatible with neutron
Changes Made
Notes
Some comments in the code in the code mention "osmosis" however I wasn't sure whether or not to change this, so please let me know if I should do this.