Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings about invalid background range #116

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Conversation

backmari
Copy link
Collaborator

@backmari backmari commented Mar 22, 2024

Short description of the changes:

The user is shown warnings when the peak range is not inside the background range. However, these warnings are obsolete as it is now valid to to define one or two background regions away from the peak range.

This PR removes the warnings shown here (red stars and text "INVALID SELECTION"):
Screenshot from 2024-03-20 10-42-54

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

Test changing peak and background ranges in the popup plots that appear when double-clicking either the Y vs TOF plot or the counts vs Y plot. Everything should work as before, except that there should be no red warnings about "INVALID SELECTION" shown.

References

Defect 4326: [REFRED] Eliminate "functional background" from the background settings

Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@backmari backmari merged commit ee64971 into next Mar 25, 2024
3 checks passed
@backmari backmari deleted the remove_warnings branch March 25, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants