Remove warnings about invalid background range #116
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes:
The user is shown warnings when the peak range is not inside the background range. However, these warnings are obsolete as it is now valid to to define one or two background regions away from the peak range.
This PR removes the warnings shown here (red stars and text "INVALID SELECTION"):
![Screenshot from 2024-03-20 10-42-54](https://private-user-images.githubusercontent.com/6989921/315840529-70ba5099-3f5d-4307-a68e-9346c036ad55.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk5MzYwNzQsIm5iZiI6MTczOTkzNTc3NCwicGF0aCI6Ii82OTg5OTIxLzMxNTg0MDUyOS03MGJhNTA5OS0zZjVkLTQzMDctYTY4ZS05MzQ2YzAzNmFkNTUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTlUMDMyOTM0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Yjk3MDkzNWE0MzBhNzliZjMyMWZkY2UxOWMzYTA3ODRjN2IxYmJmMzYzOTc5ZmExNzIzMDhjMjU4MjU2YTYxNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.jLKqAyrqhqfF54NNQw5YXwjqyU_R1p60EG4DXhFYIi4)
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
Test changing peak and background ranges in the popup plots that appear when double-clicking either the Y vs TOF plot or the counts vs Y plot. Everything should work as before, except that there should be no red warnings about "INVALID SELECTION" shown.
References
Defect 4326: [REFRED] Eliminate "functional background" from the background settings