Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dead time to scaling factor calculation #118

Merged
merged 14 commits into from
Apr 23, 2024
Merged

Add dead time to scaling factor calculation #118

merged 14 commits into from
Apr 23, 2024

Conversation

mdoucet
Copy link
Member

@mdoucet mdoucet commented Apr 12, 2024

Add dead time option to scaling factor calculation

  • Add dialog to select options
  • Use lr_reduction v 2.0.22 to compute the scaling factors
  • Update the reduction_sf_calculator.generate_script() method to use the new call.
  • Fix mock tests

@mdoucet mdoucet requested a review from jmborr April 23, 2024 13:24
Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks 👌

@mdoucet mdoucet merged commit e9275ef into next Apr 23, 2024
3 checks passed
@mdoucet mdoucet deleted the add_sf_dt branch April 23, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants