Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read/Save dead-time options to global state #122

Merged
merged 11 commits into from
May 7, 2024
Merged

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented May 3, 2024

References

Description of the changes:

New class DeadTimeSettingsModel stores the state of the dead time settings for the Main GUI.

Manual test for the reviewer

Before running the manual tests, install the conda environment and install the source in editable mode

> conda env create --solver libmamba --name refred-dev --file ./environment.yml
> conda activate refred-dev
(refred-dev)> pip install -e .

Start RefRed GUI

(refred-dev)> PYTHONPATH=$(pwd):$PYTHONPATH ./scripts/start_refred.py

Then in the Dead Time Correction group, click in Apply, then Settings to open the settings dialog which will show default values. Change any value, then close the dialog. After this reopen the dialog to make sure the values are persistent.

Check list for the reviewer

  • I have verified the proposed changes
  • Author included tests for the proposed changes
  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
    • new functions and classes detailed docstrings, parameters documented
  • All tests are passing
  • Documentation is up to date

Check list for the author

  • I have added tests for my changes
  • I have updated the documentation accordingly
  • I included a link to IBM EWM Story or Defect

@codecov-commenter
Copy link

codecov-commenter commented May 3, 2024

Codecov Report

Attention: Patch coverage is 89.18919% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 60.56%. Comparing base (b1e4ae1) to head (86eb419).

Files Patch % Lines
RefRed/configuration/export_xml_config.py 28.57% 5 Missing ⚠️
RefRed/configuration/saving_configuration.py 0.00% 1 Missing ⚠️
RefRed/interfaces/deadtime_settings.py 96.77% 1 Missing ⚠️
...Red/reduction/global_reduction_settings_handler.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #122      +/-   ##
==========================================
+ Coverage   60.35%   60.56%   +0.21%     
==========================================
  Files         120      121       +1     
  Lines       10157    10134      -23     
==========================================
+ Hits         6130     6138       +8     
+ Misses       4027     3996      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmborr jmborr merged commit 2114a87 into next May 7, 2024
3 checks passed
@jmborr jmborr deleted the read_save_deadtime branch May 7, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants