Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup startup configuration #144

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Cleanup startup configuration #144

merged 4 commits into from
Feb 6, 2025

Conversation

mdoucet
Copy link
Member

@mdoucet mdoucet commented Feb 5, 2025

Over the years we have cleaned up some of the configuration. This PR gets rid of a lot of dead code, which created problems for users who still had old config files lying around.

The config that existed were meant to set the default values of a few parameters: TOF binning, angle offset, etc...
Those were stored in the QSettings of the application.
There is no reason to change those defaults, and that was removed a long time ago. The following dead code was left behind:

  • There was a panel to change those parameters, and the hook in the .ui file was kept but hidden. This PR removes it.
  • Because the hook was kept, the callback function was also kept in the main application. We removed it.
  • Because the callback was kept, the unused panel code was kept too, along with a "password" panel. They are now both gone.
  • The .ui files for those panels have been removed.
  • There was useless layers of code to read/write and handle those parameters. We replaced all this with a dict.

@mdoucet mdoucet requested a review from glass-ships February 5, 2025 22:09
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.60%. Comparing base (2b5af6f) to head (fc96685).

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #144      +/-   ##
==========================================
- Coverage   63.68%   63.60%   -0.08%     
==========================================
  Files         121      117       -4     
  Lines        9915     9792     -123     
==========================================
- Hits         6314     6228      -86     
+ Misses       3601     3564      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@glass-ships glass-ships left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! doesn't seem like it'll have any conflicts with #141

@mdoucet mdoucet merged commit a04b724 into next Feb 6, 2025
3 checks passed
@mdoucet mdoucet deleted the clean_settings branch February 6, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants