Sc tests #21
Sc tests #21
Conversation
| @@ -0,0 +1,8 @@ | |||
| import numpy as np # noqa: F401 | |||
|
|
|||
| import hyspecppt.hppt.hppt_model as hppt_model # noqa: F401 | |||
There was a problem hiding this comment.
better import what you need, for example:
from hyspecppt.hppt.hppt_model import HyspecPPTModel
| @@ -0,0 +1,99 @@ | |||
| import numpy as np | |||
|
|
|||
| import hyspecppt.hppt.hppt_model as hppt_model | |||
| @@ -0,0 +1,8 @@ | |||
| import numpy as np # noqa: F401 | |||
There was a problem hiding this comment.
lets be consistent on the file names. so far the test filenames are small case separated by underscore.: e.g test_hyspecpptmodel.py
| Ei: float = DEFAULT_EXPERIMENT["Ei"] | ||
| S2: float = DEFAULT_EXPERIMENT["S2"] | ||
| alpha_p: float = DEFAULT_EXPERIMENT["alpha_p"] | ||
| plot_type: str = DEFAULT_EXPERIMENT["plot_type"] | ||
| cp: CrosshairParameters |
There was a problem hiding this comment.
is the initialization of the other parameters: CrosshairParameters and SingleCrystalParameters from the experiment_settings happening in another PR?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #21 +/- ##
==========================================
+ Coverage 91.04% 91.40% +0.35%
==========================================
Files 10 10
Lines 659 663 +4
==========================================
+ Hits 600 606 +6
+ Misses 59 57 -2 ☔ View full report in Codecov by Sentry. |
| @@ -0,0 +1,8 @@ | |||
| import numpy as np # noqa: F401 | |||
There was a problem hiding this comment.
it does not look like we need this. it can be omitted.
Short description of the changes:
This is a follow up PR for PR #18 that adds unit tests targeting single crystal and powder model.
EWM 8607
It also addresses modQ calcualtions and initialization of HyspecPPTModel class.
Long description of the changes:
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
References