From Powder to Single Crystal Mode Switch #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* sc - powder toggle switch, code cleanup * mode selection only in view during init, test updated * mode parent check on widget init * relevant test added * ei value update and passed from view-presenter-model through callback functions * experiment data update -save and restore- on powder switch * mode switch test update * tests fixed with the new changes for mode switch data passing * presenter, tests for mode switch, code cleanup, move for visibility, model left out intentionally * updates after comparing with intermediate model (model still not included) * validation simplification cleanup * selection mode init rewrite, presenter cleanup * experiment data remain valid during mode switch, tests, update
* tests for SC model * initalization and modQ change * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * pre-commit fix * precommit fix * initialization and minor changes --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Andrei Savici <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes:
In Progress
Long description of the changes:
Check list for the pull request
Check list for the reviewer
Manual test for the reviewer
References