Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crosshair updates and more #26

Merged
merged 9 commits into from
Jan 15, 2025
Merged

Crosshair updates and more #26

merged 9 commits into from
Jan 15, 2025

Conversation

mpatrou
Copy link
Collaborator

@mpatrou mpatrou commented Jan 14, 2025

Short description of the changes:

The code includes changes for the crosshair data plot update.
There is currently no plot in the view side (future story). The lines are updated in a sample plot, to demonstrate the updates occur

Long description of the changes:

The changes include:

  • code cleanup and improvements to conform naming standards, e.g. snake case, for consistency
  • tests new and updated for plot widget updates
  • plot widget updates for eline and qline parameters
  • plot parameters updates from view and presenter when data are valid

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

Display crosshair

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.90%. Comparing base (f3ccd22) to head (8a41058).

Additional details and impacted files
@@            Coverage Diff             @@
##             next      #26      +/-   ##
==========================================
+ Coverage   92.30%   92.90%   +0.59%     
==========================================
  Files          10       10              
  Lines         715      747      +32     
==========================================
+ Hits          660      694      +34     
+ Misses         55       53       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndreiSavici AndreiSavici enabled auto-merge (squash) January 15, 2025 15:23
Copy link
Member

@AndreiSavici AndreiSavici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Works as expected

@AndreiSavici AndreiSavici merged commit f7b5f76 into next Jan 15, 2025
3 checks passed
@AndreiSavici AndreiSavici deleted the crosshair_updates branch January 15, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants