Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include tests requiring git lfs in CI pipeline #106

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Conversation

backmari
Copy link
Collaborator

@backmari backmari commented Oct 15, 2024

Description of work:

  • stop skipping tests with the marker datarepo
  • cache the files in the test data submodule
  • update dead-time correction gold values that changed due to Fix dead time at 30 Hz #102
  • skip test depending on the data repo that only fails in the CI pipeline (defect created: EWM7743)

Verified that the git lfs files are successfully loaded from the cache:

image

Check all that apply:

  • added release notes
    (if not, provide an explanation in the work description)
  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • Verified that tests requiring the /SNS and /HFIR filesystems pass without fail

References:

  • Links to IBM EWM items:
  • Links to related issues or pull requests:

Manual test for the reviewer

(instructions to set up the environment)

Check list for the reviewer

  • release notes updated,
    or an explanation is provided as to why release notes are unnecessary
  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.57%. Comparing base (71eaf39) to head (cc73cb9).
Report is 1 commits behind head on next.

Additional details and impacted files
@@             Coverage Diff             @@
##             next     #106       +/-   ##
===========================================
+ Coverage   45.11%   58.57%   +13.45%     
===========================================
  Files          33       33               
  Lines        6330     6330               
===========================================
+ Hits         2856     3708      +852     
+ Misses       3474     2622      -852     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- cache LFS files
- update gold data after deadtime correction changes
- skip test that only fails in the CI job
Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@backmari please update the release notes

@backmari backmari merged commit 8174025 into next Oct 21, 2024
3 checks passed
@backmari backmari deleted the ci_git_lfs_tests branch October 21, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants