Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick Qt bug fix into qa branch - attempt 2 #111

Merged
merged 10 commits into from
Dec 4, 2024
Merged

Cherry pick Qt bug fix into qa branch - attempt 2 #111

merged 10 commits into from
Dec 4, 2024

Conversation

backmari
Copy link
Collaborator

@backmari backmari commented Dec 4, 2024

Description of work:

Check all that apply:

  • added release notes
    (if not, provide an explanation in the work description)
  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests

References:

  • Links to IBM EWM items:
  • Links to related issues or pull requests:

Manual test for the reviewer

(instructions to set up the environment)

Check list for the reviewer

  • release notes updated,
    or an explanation is provided as to why release notes are unnecessary
  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.48%. Comparing base (a90c34f) to head (38305de).

Additional details and impacted files
@@             Coverage Diff             @@
##               qa     #111       +/-   ##
===========================================
+ Coverage   45.11%   58.48%   +13.36%     
===========================================
  Files          33       33               
  Lines        6330     6330               
===========================================
+ Hits         2856     3702      +846     
+ Misses       3474     2628      -846     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@backmari backmari merged commit dd33456 into qa Dec 4, 2024
3 checks passed
@backmari backmari deleted the qa_test2 branch December 4, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants