Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI test PR #126

Closed
wants to merge 1 commit into from
Closed

CI test PR #126

wants to merge 1 commit into from

Conversation

backmari
Copy link
Collaborator

Description of work:

Check all that apply:

  • added release notes
    (if not, provide an explanation in the work description)
  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests

References:

  • Links to IBM EWM items:
  • Links to related issues or pull requests:

Manual test for the reviewer

(instructions to set up the environment)

Check list for the reviewer

  • release notes updated,
    or an explanation is provided as to why release notes are unnecessary
  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@backmari backmari marked this pull request as draft January 28, 2025 16:08
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.77%. Comparing base (7524362) to head (2e35605).

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #126   +/-   ##
=======================================
  Coverage   60.77%   60.77%           
=======================================
  Files          33       33           
  Lines        6560     6560           
=======================================
  Hits         3987     3987           
  Misses       2573     2573           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@backmari backmari closed this Jan 28, 2025
@backmari backmari deleted the backmari-patch-1 branch January 28, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants