Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global configuration changed when selecting a run #78

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

backmari
Copy link
Collaborator

@backmari backmari commented Apr 17, 2024

Short description of the changes:

Add ConfigurationHandler which connects signals from global configuration parameter UI widgets to callbacks updating the corresponding Configuration class variable.

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

  1. Load two runs (e.g. 42536 and 42537) and add them to the reduction table
  2. Modify a value in the panel "Reflectivity Extraction (Global)"
  3. Double click a different run in the column "Run No." in the reduction table
  4. Verify that the config value changed in 2. is still the same

References

Defect 4758: [QUICKNXS] Global options updated when selecting a run

@backmari backmari changed the title Global config defect Global configuration changed when selecting a run Apr 17, 2024
@backmari backmari force-pushed the global_config_defect branch 3 times, most recently from 297cedd to 302ace6 Compare April 23, 2024 11:52
…ignals from the UI

- remove obsolete remove_files.py
@backmari backmari force-pushed the global_config_defect branch from 302ace6 to b8432ca Compare April 23, 2024 13:42
Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks 👌

@backmari backmari merged commit 1e4e8be into next Apr 24, 2024
3 checks passed
@backmari backmari deleted the global_config_defect branch April 24, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants