Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified data file path #80

Closed
wants to merge 11 commits into from

Conversation

dmitry-ganyushin
Copy link
Collaborator

Short description of the changes:

A data repo for reflectivity test is created. New path to find data is adjusted.

Long description of the changes:

Check list for the pull request

  • [ x] I have read the [CONTRIBUTING]
  • [ x] I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

pytest -v

References

Story 4822

@dmitry-ganyushin dmitry-ganyushin force-pushed the data-repo-reflectivity-test-data branch 2 times, most recently from 0fc0a43 to c15f22b Compare May 2, 2024 13:03
@dmitry-ganyushin dmitry-ganyushin force-pushed the data-repo-reflectivity-test-data branch from 010b218 to 55ebced Compare May 2, 2024 13:12
@dmitry-ganyushin dmitry-ganyushin force-pushed the data-repo-reflectivity-test-data branch from 59fe42b to 113046d Compare May 2, 2024 15:12
@dmitry-ganyushin dmitry-ganyushin force-pushed the data-repo-reflectivity-test-data branch from 7d14b39 to 069ecf2 Compare May 3, 2024 14:29
@dmitry-ganyushin dmitry-ganyushin force-pushed the data-repo-reflectivity-test-data branch from a945027 to a0e61ae Compare May 3, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant