Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the test test_manager #90

Merged
merged 2 commits into from
May 22, 2024
Merged

Fix for the test test_manager #90

merged 2 commits into from
May 22, 2024

Conversation

dmitry-ganyushin
Copy link
Collaborator

Short description of the changes:

Long description of the changes:

Check list for the pull request

  • [X ] I have read the [CONTRIBUTING]
  • [ X] I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@dmitry-ganyushin
Copy link
Collaborator Author

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 35.41%. Comparing base (7f4ceab) to head (a2bf8d1).

Files Patch % Lines
reflectivity_ui/interfaces/data_manager.py 0.00% 2 Missing ⚠️
...ectivity_ui/interfaces/data_handling/instrument.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             next      #90   +/-   ##
=======================================
  Coverage   35.41%   35.41%           
=======================================
  Files          30       30           
  Lines        6091     6091           
=======================================
  Hits         2157     2157           
  Misses       3934     3934           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks 👌

@dmitry-ganyushin dmitry-ganyushin merged commit 3431700 into next May 22, 2024
3 checks passed
@dmitry-ganyushin dmitry-ganyushin deleted the test_manager_wip branch May 22, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants