Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback option for loading data #94

Merged
merged 6 commits into from
Jul 1, 2024
Merged

Add fallback option for loading data #94

merged 6 commits into from
Jul 1, 2024

Conversation

mdoucet
Copy link
Member

@mdoucet mdoucet commented Jun 28, 2024

Occasionally, and for older data, the current way of filtering data fails.
In this case, we case use another PV to do the filtering.

This PR also fixed a small bug where the reduction would fail if there was only one cross-section because it was assuming that the return value of the reduction Mantid algo was a iterable.

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 15.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 35.16%. Comparing base (d11eaee) to head (5855a66).

Files Patch % Lines
...flectivity_ui/interfaces/data_handling/data_set.py 0.00% 8 Missing ⚠️
...ectivity_ui/interfaces/data_handling/instrument.py 0.00% 6 Missing ⚠️
reflectivity_ui/interfaces/data_manager.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next      #94      +/-   ##
==========================================
- Coverage   35.26%   35.16%   -0.11%     
==========================================
  Files          30       30              
  Lines        6085     6100      +15     
==========================================
- Hits         2146     2145       -1     
- Misses       3939     3955      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdoucet mdoucet requested a review from backmari June 28, 2024 19:52
Copy link
Collaborator

@backmari backmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change allows loading a run where the sample log required by MRFilterCrossSections is missing due to a problem in the data acquisition. Before this change, loading the run number 42006 fails. After the change, loading run 42006 succeeds by instead filtering by the log BL4A:SF:ICP:getDI. There is a log message and a status bar message to warn the user about the different filtering used.
Other than my question/comment about the return when qmin is None, this looks good to me.

@mdoucet mdoucet merged commit d8cb33c into next Jul 1, 2024
3 checks passed
@mdoucet mdoucet deleted the load_plan_b branch July 1, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants