-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fallback option for loading data #94
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #94 +/- ##
==========================================
- Coverage 35.26% 35.16% -0.11%
==========================================
Files 30 30
Lines 6085 6100 +15
==========================================
- Hits 2146 2145 -1
- Misses 3939 3955 +16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change allows loading a run where the sample log required by MRFilterCrossSections
is missing due to a problem in the data acquisition. Before this change, loading the run number 42006 fails. After the change, loading run 42006 succeeds by instead filtering by the log BL4A:SF:ICP:getDI
. There is a log message and a status bar message to warn the user about the different filtering used.
Other than my question/comment about the return when qmin
is None
, this looks good to me.
Occasionally, and for older data, the current way of filtering data fails.
In this case, we case use another PV to do the filtering.
This PR also fixed a small bug where the reduction would fail if there was only one cross-section because it was assuming that the return value of the reduction Mantid algo was a iterable.