Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete all references to genx in the souce code #96

Merged
merged 2 commits into from
Jul 11, 2024
Merged

delete all references to genx in the souce code #96

merged 2 commits into from
Jul 11, 2024

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Jul 11, 2024

Short description of the changes:

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.37%. Comparing base (d8cb33c) to head (b5ae22b).

Additional details and impacted files
@@            Coverage Diff             @@
##             next      #96      +/-   ##
==========================================
+ Coverage   35.16%   35.37%   +0.20%     
==========================================
  Files          30       30              
  Lines        6100     6061      -39     
==========================================
- Hits         2145     2144       -1     
+ Misses       3955     3917      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jose Borreguero <[email protected]>
@jmborr jmborr merged commit 6f1405b into next Jul 11, 2024
3 checks passed
@jmborr jmborr deleted the genx_remove branch July 11, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants