Skip to content

Commit

Permalink
Don't include steep in the dev-deps
Browse files Browse the repository at this point in the history
instead, put it in the Gemfile, and allow an ENV to exclude it, which we
can then supply in the rspec github actions. We need to run tests in
environments that steep doesn't support, and gemspecs don't (as yet)
support optional dev dependencies.
  • Loading branch information
nevinera committed Nov 14, 2023
1 parent a454764 commit 40a118f
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .github/workflows/rspec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ jobs:
fail-fast: false
matrix:
ruby-version: ['2.7', '3.0', '3.1', '3.2', 'head']
env:
NO_STEEP: "Because we need to test on versions that are older than steep supports"

steps:
- uses: actions/checkout@v3
Expand Down
4 changes: 4 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
source "https://rubygems.org"

gemspec

unless ENV["NO_STEEP"]
gem "steep", "~> 1.6.0"
end
1 change: 0 additions & 1 deletion environment_helpers.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,4 @@ Gem::Specification.new do |spec|
spec.add_development_dependency "rubocop", "~> 1.50"
spec.add_development_dependency "quiet_quality", "~> 1.3.0"
spec.add_development_dependency "mdl", "~> 0.12"
spec.add_development_dependency "steep", "~> 1.6.0"
end

0 comments on commit 40a118f

Please sign in to comment.