Allow command/exec_command overrides via yaml config #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing uses it yet, but you can include a 'command' array (of strings) for each runner in your yaml config.
It's the first option (that isn't part of the file-filtering, which has its own handling) that has a tool-specific and no global option, so we need a new `global` param on `update_tool_option`.
(it _is_ a relevant runner, but it handles the commands itself, because it's _special_..)
zmariscal
approved these changes
May 8, 2024
| let(:changed_files) { fully_changed_files(relevant_name, irrelevant_name) } | ||
|
|
||
| context "but none matching the file_filter" do | ||
| let(:file_filter) { /never_gonna_give_you_up/ } |
There was a problem hiding this comment.
Just reviewing away and then BAM. CodeRolled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows one to accommodate a lot of atypical situations, where rspec (for example) needs to be supplied with additional arguments (like a load path, a pattern, etc).
We do not yet support supplying this configuration on the CLI, but each tool may supply a
commandand/orexec_commandvalue in the yaml config. If it does, that will be used instead of the built-in command (note that RelevantRunner will still suffix the list of files in the usual cases).Updating your config file to add
rspec: { exec_command: ["rspec", "-f", "d"] }for example will makeqq -Xrspecrun in documentation format. Though that's a lot of output in most test suites :-)