XKit Preferences: Cancel first-install tour on any successful click #2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hobinjk
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've got a user report in DMs in which the "Welcome to XKit! Let's get started." interface appears and makes the Tumblr UI inaccessible. I have no explanation for exactly how this could occur, and troubleshooting hasn't uncovered it. The user has been opening Tumblr to a non-dashboard page to get around the tour interface.
This PR moves the "end tour" logic so that it applies on any successful XKit preferences button click, instead of only when the button is clicked from the tour interface. Presumably if a user has found the button, they no longer need a tour.
This should be copied into the 7.9.2 branch as well (note: copy the whole xkit_preferences.js and xkit_preferences.css files rather than cherry picking).