Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): Fixes mysqli test by adding missing slowsql #882

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

mfulb
Copy link
Contributor

@mfulb mfulb commented Apr 25, 2024

A EXPECT_SLOW_SQLS specification was left out of one test from PR #881 .

@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Apr 25, 2024

Test Suite Status Result
Multiverse cancelled 🚫 8/9 passing
SOAK 56/56 passing

@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.72%. Comparing base (ac8271c) to head (3ef1286).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #882   +/-   ##
=======================================
  Coverage   78.72%   78.72%           
=======================================
  Files         193      193           
  Lines       27214    27214           
=======================================
  Hits        21423    21423           
  Misses       5791     5791           
Flag Coverage Δ
agent-for-php-7.0 77.45% <ø> (ø)
agent-for-php-7.1 77.21% <ø> (?)
agent-for-php-7.2 78.13% <ø> (ø)
agent-for-php-7.3 78.15% <ø> (ø)
agent-for-php-7.4 77.86% <ø> (ø)
agent-for-php-8.0 77.92% <ø> (ø)
agent-for-php-8.1 77.91% <ø> (ø)
agent-for-php-8.2 77.51% <ø> (ø)
agent-for-php-8.3 77.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfulb mfulb merged commit 732ebb8 into dev Apr 25, 2024
62 checks passed
@mfulb mfulb deleted the fixes/mysqli-add-missing-slowsql-integration branch April 25, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants