NR Control Health Checks

[umaannamalai]

Before contributing, please read our contributing guidelines and code of conduct.

Overview

Describe the changes present in the pull request

Related Github Issue

Include a link to the related GitHub issue, if applicable

Testing

The agent includes a suite of tests which should be used to
verify your changes don't break existing functionality. These tests will run with
Github Actions when a pull request is made. More details on running the tests locally can be found
here,
For most contributions it is strongly recommended to add additional tests which
exercise your changes.

[github-actions]

🦙 MegaLinter status: ❌ ERROR

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ PYTHON	bandit	6		0	6.72s
✅ PYTHON	black	9	6	0	3.22s
❌ PYTHON	flake8	9		5	1.41s
✅ PYTHON	isort	9	9	0	0.27s
✅ PYTHON	pylint	9		0	10.3s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 87.36842% with 24 lines in your changes missing coverage. Please review.

Please upload report for BASE (super-agent@5e48f62). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
newrelic/core/super_agent_health.py	91.05%	8 Missing and 3 partials ⚠️
newrelic/config.py	85.29%	4 Missing and 1 partial ⚠️
newrelic/core/application.py	69.23%	3 Missing and 1 partial ⚠️
newrelic/core/agent.py	60.00%	1 Missing and 1 partial ⚠️
newrelic/core/agent_protocol.py	86.66%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@              Coverage Diff               @@
##             super-agent    #1250   +/-   ##
==============================================
  Coverage               ?   81.22%           
==============================================
  Files                  ?      202           
  Lines                  ?    22352           
  Branches               ?     3545           
==============================================
  Hits                   ?    18155           
  Misses                 ?     3020           
  Partials               ?     1177           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[TimPansino]

There were way too many string comparisons and hard coded strings going on in the super agent health file, so I've refactored it somewhat.

I'm looking for it to use integers in every conceivable spot to minimize string comparisons and copies, as well as reduce the risk of a future change introducing bugs because we're comparing status messages that are hard coded in 2 places, rather than using integer codes.

To that end, I've redone the file to use the original integer codes as the enum values, eliminated all cases where we have a string like NR-APM-003, and instead construct those when writing out to the file. I removed all hard coded references and replaced them with integers referenced via enum.

I also removed the large block of logic to construct different status messages and modeled it somewhat after the logic used in newrelic/core/agent_protocol.py to always attempt to format the string with the passed in values, and rely on string formatting to throw away unused values.

[hmstepanek]

Looks good!