Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore - Update Linter Configs #1273

Merged
merged 6 commits into from
Dec 16, 2024
Merged

Chore - Update Linter Configs #1273

merged 6 commits into from
Dec 16, 2024

Conversation

TimPansino
Copy link
Contributor

@TimPansino TimPansino commented Dec 13, 2024

Overview

  • Add .gitignore entry for pre-commit config file
  • Update configuration for various linters
  • Add flynt configuration to pyproject.toml
  • Run flynt against repo to fix more fstrings

@TimPansino TimPansino requested a review from a team as a code owner December 13, 2024 22:02
Copy link

github-actions bot commented Dec 13, 2024

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON bandit 2 0 4.82s
✅ PYTHON black 6 0 0 0.97s
❌ PYTHON flake8 6 3 0.56s
✅ PYTHON isort 6 0 0 0.32s
✅ PYTHON pylint 6 0 3.06s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.61%. Comparing base (57ba3fb) to head (f202c34).

Files with missing lines Patch % Lines
newrelic/api/llm_custom_attributes.py 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (57ba3fb) and HEAD (f202c34). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (57ba3fb) HEAD (f202c34)
8 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1273       +/-   ##
===========================================
- Coverage   81.28%   28.61%   -52.67%     
===========================================
  Files         201      201               
  Lines       22173    22173               
  Branches     3519     3519               
===========================================
- Hits        18023     6345    -11678     
- Misses       2983    15077    +12094     
+ Partials     1167      751      -416     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mergify mergify bot removed the tests-failing label Dec 13, 2024
@TimPansino TimPansino merged commit 25e1f1e into main Dec 16, 2024
55 of 56 checks passed
@TimPansino TimPansino deleted the chore-linter-configs branch December 16, 2024 21:11
@umaannamalai umaannamalai added this to the v10.5.0 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants