Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional metadata to vectorstore results #1290

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

lrafeei
Copy link
Contributor

@lrafeei lrafeei commented Jan 24, 2025

This PR adds metadata.page_label search result to the vectorstore events tests

Copy link

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 1 0 0 0.66s
✅ PYTHON flake8 1 0 0.36s
✅ PYTHON isort 1 0 0 0.19s
✅ PYTHON pylint 1 0 1.74s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.27%. Comparing base (9dd76a8) to head (81e03b3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1290      +/-   ##
==========================================
- Coverage   81.31%   81.27%   -0.04%     
==========================================
  Files         201      201              
  Lines       22174    22174              
  Branches     3519     3519              
==========================================
- Hits        18030    18022       -8     
- Misses       2979     2985       +6     
- Partials     1165     1167       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrafeei lrafeei marked this pull request as ready for review January 24, 2025 19:37
@lrafeei lrafeei requested a review from a team as a code owner January 24, 2025 19:37
@lrafeei lrafeei merged commit 454709e into main Jan 24, 2025
55 of 56 checks passed
@lrafeei lrafeei deleted the fix-langchain-pagesplitter-test branch January 24, 2025 22:26
@mergify mergify bot removed the tests-failing label Jan 24, 2025
@umaannamalai umaannamalai added this to the v10.5.0 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants