Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: limit concurrency of nightly tf #242

Merged
merged 1 commit into from
Feb 21, 2025
Merged

ci: limit concurrency of nightly tf #242

merged 1 commit into from
Feb 21, 2025

Conversation

kb-newrelic
Copy link
Contributor

@kb-newrelic kb-newrelic commented Feb 21, 2025 •
edited
Loading

Summary

  • Having nightly apply the tf for each distro concurrently causes deadlocks in dynamoDB and state corruption when one tf fails and kills the other one.
  • Following github docs using concurrency groups to limit concurrency to 1

@kb-newrelic kb-newrelic requested a review from a team as a code owner February 21, 2025 20:31
mailo-nr
mailo-nr approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@mailo-nr mailo-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kb-newrelic kb-newrelic force-pushed the kbauer/run-terraform-in-sequence branch from 7a15bb3 to ff10b9b Compare February 21, 2025 20:51
@kb-newrelic kb-newrelic merged commit 9b7ca17 into main Feb 21, 2025
7 checks passed
@kb-newrelic kb-newrelic deleted the kbauer/run-terraform-in-sequence branch February 21, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mailo-nr mailo-nr mailo-nr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kb-newrelic @mailo-nr