Skip to content

Commit

Permalink
ssh: switch from parallel-ssh to ansible-pylibssh
Browse files Browse the repository at this point in the history
Unfortunately, parallel-ssh has become a dead project incompatible
with python-3.12+. Some effort was created by its community to make
it compatible, unfortunately the only maintainer with write access
is unresponsive and there is not much hope for a new release.

Therefore we switch to ansible-pylibssh, which provides low level
libssh python bindings. There is significant performance impact
in artificial test case ("running 'exit 0' over and over again is twice
as slow) due to differences in poll implementation, however the impact
is neglitable in real world scenarios (~20 seconds delay on 350 test
cases). This small slowdown also provides a huge benefit in very small
CPU usage 0-1% where parallel-ssh keeps spinning on 10-11%.
  • Loading branch information
pbrezina committed Jun 10, 2024
1 parent 8b6420a commit d027f50
Show file tree
Hide file tree
Showing 3 changed files with 237 additions and 113 deletions.
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ files = ["requirements.txt"]
source = "vcs"

[[tool.mypy.overrides]]
module = ["pssh.*", "pytest_output.*"]
module = ["pylibsshext.*", "pytest_output.*"]
ignore_missing_imports = true

[tool.isort]
Expand Down
Loading

0 comments on commit d027f50

Please sign in to comment.