-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Application.php): Update methods post-refactor #3380
Conversation
Fixes #3363. The refactor in #3315 swapped around a few methods and this updates Application.php to use the appropriate ones. Signed-off-by: Josh Richards <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this solved the issue
Thanks @joshtrichards I'm puzzled why psalm has not thrown an error for this case, but that is not a blocker for getting this in of course. |
/backport to stable28 |
The fix works for eliminating the errors. But It now hangs on uploading large files, like ISOs onto Nextcloud. Some instances crash. others just dont finalize the upload. I got NC instances where I did not apply this fix, there its working. on 3 instances, where I applied this fix, I got this problem. waiting on a new release. |
@gehkah Please open a bug report so that we can get the info needed to solve that. I'm afraid a mere comment on the original PR isn't sufficient to reproduce + fix the problem you're reporting (if it is, indeed, even related) |
Dear Josh I'm sorry for the circumstances. I upgraded to php8.3 and the problems are gone on my instances. I applied your fix to other NC instances and reproduces the problem unter php8.2 (VM, debian bullseye, apache2) but when I upgraded these to php 8.3, the problem no longer exists. No more 100% cpu usage or vm crash, I'm able to upload ISOs again. I'm fine with it. thank you very much!! |
Summary
The refactor in #3315 swapped around a few methods and this updates Application.php to use the appropriate ones.
Checklist