Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add setup checks and verify WOPI connectivity #4470

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add setup checks and verify WOPI connectivity #4470

wants to merge 1 commit into from

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Feb 13, 2025 •
edited
Loading

  • Add a setup check to verify that we are running the latest Collabora release
  • Add a setup check to verify connectivity with the collabora server
  • Extend the connectivity checks with using the new Collabora endpoint to verify WOPI access (that Collabora can reach Nextcloud)

Needs CollaboraOnline/online#11162 for self-signed certificates that are not trusted on Collabora (without validation)

Screenshot 2025-02-13 at 23 03 14 Screenshot 2025-02-13 at 23 26 25

elzody
elzody reviewed Feb 13, 2025
View reviewed changes
lib/Service/ConnectivityService.php Outdated

public function testWopiAccess(?OutputInterface $output = null): void {
$client = $this->clientService->newClient();
return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch, was from testing and finding that upstream bug :)

@juliusknorr juliusknorr added 3. to review Ready to be reviewed enhancement New feature or request labels Feb 13, 2025
@juliusknorr juliusknorr marked this pull request as ready for review February 13, 2025 22:27
@juliusknorr juliusknorr requested a review from a team February 13, 2025 22:28
@juliusknorr
Copy link
Member Author

juliusknorr commented Feb 13, 2025 •
edited
Loading

Host "localhost" violates local access rules

Interesting integration test failure, wondering why it still worked fine before, maybe another collabora bug there or we just did not run into any WOPI call that could trigger it before?

@blizzz
Copy link
Member

blizzz commented Feb 13, 2025 •
edited
Loading

Host "localhost" violates local access rules

Interesting integration test failure, wondering why it still worked fine before, maybe another collabora bug there or we just did not run into any WOPI call that could trigger it before?

Maybe need to specify 'allow_local_remote_servers' => true, in the config.php.

Cf. \OC\Http\Client\Client::preventLocalAddress() on server

@juliusknorr
Copy link
Member Author

Right, assumed it on the wrong (collabora) end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elzody elzody elzody left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
3. to review Ready to be reviewed enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusknorr @blizzz @elzody