Skip to content

Commit

Permalink
Merge pull request #379 from nextmcloud/nmc/3561-optimized-accessibility
Browse files Browse the repository at this point in the history 
fixed multiple accessibility issues
  • Loading branch information
@memurats
memurats authored Nov 28, 2024
2 parents 7312299 + c94f526 commit 566a70b
Show file tree
Hide file tree
Showing 28 changed files with 4,589 additions and 3,657 deletions.
130 changes: 67 additions & 63 deletions css/apps/files-right-click.scss
View file
Original file line number Diff line number Diff line change
@@ -1,83 +1,87 @@
@import '../_mixins.scss';

.files-list {

.v-popper__popper {
ul li {
&.action {
button {
svg {
display: none;
}
}
}

&[data-cy-files-list-row-action="details"],
&[data-cy-files-list-row-action="edit-locally"],
&[data-cy-files-list-row-action="view"],
&[data-cy-files-list-row-action="cancel_select"],
&[data-cy-files-list-row-action="sharing-status"],
&[data-cy-files-list-row-action="sharing-status-magentacloud"],
&[data-cy-files-list-row-action="office-open-pdf"]
{
display: none;
}
ul {
display: flex;
flex-direction: column;

li {
display: flex;

&[data-cy-files-list-row-action="favorite"] {
&.action {
button {
svg {
display: none;
}
}
}

&[data-cy-files-list-row-action="details"],
&[data-cy-files-list-row-action="edit-locally"],
&[data-cy-files-list-row-action="view"],
&[data-cy-files-list-row-action="sharing-status"],
&[data-cy-files-list-row-action="sharing-status-magentacloud"],
&[data-cy-files-list-row-action="office-open-pdf"],
&[data-cy-files-list-row-action="cancel_select"]
{
display: none;
pointer-events: none;
user-select: none;
}

span.icon-vue {
background-image: var(--icon-starred-yellow);
background-size: 24px;
}

&:hover {
&[data-cy-files-list-row-action="favorite"] {
span.icon-vue {
filter: none;
background-image: var(--icon-starred-yellow);
}
}
}

span.icon-vue {
background-size: 24px;
}


&[data-cy-files-list-row-action="rename"] {
span.icon-vue {
background-image: var(--icon-edit-dark);

&[data-cy-files-list-row-action="rename"] {
span.icon-vue {
background-image: var(--icon-edit-dark);
}
}
}

&[data-cy-files-list-row-action="move-copy"] {
span.icon-vue {
background-image: var(--icon-cut-paste-dark);

&[data-cy-files-list-row-action="move-copy"] {
span.icon-vue {
background-image: var(--icon-cut-paste-dark);
}
}
}

&[data-cy-files-list-row-action="download"] {
span.icon-vue {
background-image: var(--icon-download-dark);

&[data-cy-files-list-row-action="download"] {
span.icon-vue {
background-image: var(--icon-download-dark);
}
}
}

&[data-cy-files-list-row-action="delete"] {
span.icon-vue {
background-image: var(--icon-delete-dark);

&[data-cy-files-list-row-action="delete"] {
span.icon-vue {
background-image: var(--icon-delete-dark);
}
}
}

&[data-cy-files-list-row-action="view-in-folder"] {
span.icon-vue {
background-image: var(--icon-folder-dark);

&[data-cy-files-list-row-action="view-in-folder"] {
span.icon-vue {
background-image: var(--icon-folder-dark);
}
}
}

&[data-cy-files-list-row-action="files_zip"] {
span.icon-vue {
background-image: var(--icon-compress-zip-dark);

&[data-cy-files-list-row-action="files_zip"] {
span.icon-vue {
background-image: var(--icon-compress-zip-dark);
}
}
}

&[data-cy-files-list-row-action="sharing-status-menu"] {
span.icon-vue {
background-image: var(--icon-shared-dark);

&[data-cy-files-list-row-action="sharing-status-menu"] {
span.icon-vue {
background-image: var(--icon-shared-dark);
}
}
}
}
Expand Down
71 changes: 9 additions & 62 deletions css/apps/files.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@
@mixin files-checkboxes-v28 {
span.checkbox-radio-switch-checkbox {
span.checkbox-content {
background: unset;
padding: 0;

&:hover {
Expand Down Expand Up @@ -390,8 +391,14 @@ table.files-filestable {
}

&row-name {
margin-left: 1rem;
width: 100vw;

.files-list__column-sort-button {
padding: 0;
margin: 0;
}

@include files-table-columns-v28;
}

Expand All @@ -404,8 +411,7 @@ table.files-filestable {

.files-list__column-sort-button {
padding: 0;
margin-left: 0;
margin-right: 0;
margin: 0;
}

@include files-table-columns-v28;
Expand All @@ -416,6 +422,7 @@ table.files-filestable {
tbody:not(.files-list__tbody--grid) {

.files-list__row-icon {
flex: 0 0 3rem;
margin-right: 1rem;
margin-left: 1rem;
z-index: 100;
Expand Down Expand Up @@ -460,8 +467,6 @@ table.files-filestable {

td {
.files-list__row-icon {
height: 50px;
width: 50px;

img {
background-color: unset;
Expand Down Expand Up @@ -697,25 +702,6 @@ table.files-filestable {
}
}
}

// Files menu items
.v-popper__popper .v-popper__wrapper .v-popper__inner ul li.action {
&.files-list__row-action-sharing-status {
display: none;
}

&>button.action-button {
li.action.files-list__row-action-favorite {

button.action-button {
span svg {
display: none;
}
}
}
}

}
}
}

Expand Down Expand Up @@ -832,42 +818,3 @@ table.files-filestable {
}
}
}

// Files actions menu items
.v-popper__popper.action-item__popper {

li.action {

.icon-vue {
background-size: 24px;
}

.icon-vue svg {
display: none;
}

&.files-list__row-actions-batch-delete .icon-vue {
background-image: var(--icon-delete-dark);
}

&.files-list__row-actions-batch-favorite .icon-vue {
background-image: var(--original-icon-star-dark);
}

&.files-list__row-actions-batch-move-copy .icon-vue {
background-image: var(--icon-external-dark);
}

&.files-list__row-actions-batch-download .icon-vue {
background-image: var(--icon-download-dark);
}

&.files-list__row-actions-batch-files_zip .icon-vue {
background-image: var(--icon-compress-zip-dark);
}

&.files-list__row-actions-batch-cancel_select .icon-vue {
background-image: var(--icon-close-dark);
}
}
}
19 changes: 10 additions & 9 deletions css/apps/photos.scss
View file
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,7 @@
padding: 4rem 1.5rem 1.5rem;

li.app-navigation-entry-wrapper {
order: 2;

&>.app-navigation-entry:has(a[title="Shared with you"]),
&>.app-navigation-entry:has(a[title="Mit Ihnen geteilt"]) {
Expand All @@ -384,12 +385,19 @@
display: none;
}

&[data-id-app-nav-item="favorites"] {
order: 1;
}

.app-navigation-entry-icon {
background-image: none;
width: 48px;
height: 48px;
flex: 0 0 48px;

span.material-design-icon {
width: 44px;
height: 44px;
width: 48px;
height: 48px;
background-position: center;
background-repeat: no-repeat;
background-size: 24px;
Expand Down Expand Up @@ -598,13 +606,6 @@
min-height: unset;
}

.dialog__actions {

.upload-picker {
display: block;
}
}

.photos-picker {

.file-container {
Expand Down
Loading

0 comments on commit 566a70b

Please sign in to comment.