Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new favicon touch #342

Merged
merged 1 commit into from
May 23, 2024
Merged

new favicon touch #342

merged 1 commit into from
May 23, 2024

Conversation

memurats
Copy link
Contributor

No description provided.

@memurats memurats added the custom New theme feature label May 23, 2024
@memurats memurats self-assigned this May 23, 2024
liviu-preda-tsystems
liviu-preda-tsystems reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@liviu-preda-tsystems liviu-preda-tsystems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @memurats , do we close this PR as this asset was already added in PR #343 ?

@memurats
Copy link
Contributor Author

Hi @memurats , do we close this PR as this asset was already added in PR #343 ?

Hi @liviu-preda-tsystems no, the other one is the wrong one, this has to be merged.

@liviu-preda-tsystems liviu-preda-tsystems merged commit b58e494 into main May 23, 2024
5 checks passed
@memurats memurats deleted the nmc/3047-new-touch-icon branch June 25, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liviu-preda-tsystems liviu-preda-tsystems liviu-preda-tsystems approved these changes

@aleksei-nmc aleksei-nmc Awaiting requested review from aleksei-nmc

Assignees

@memurats memurats

Labels
custom New theme feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@memurats @liviu-preda-tsystems