Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version nextclade binary for transition, i.e. nextclade -> nextclade2 #226

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

corneliusroemer
Copy link
Member

Soon we will release nextclade v3. Once nextclade v3 hits bioconda, workflows that rely on v2 syntax will break. To prevent this, this PR makes it explicit that the syntax used is for v2 and that the v2 binary nextclade2 should be used.

This binary is in both the nextstrain-base docker image and in the conda-base managed conda environment.

Users who don't use either will have to add nextclade2 to the path.

Over the next few weeks, we will transition repos to use nextclade3. The reason to add nextclade2 now is so that workflows don't break if they haven't yet transitioned to nextclade3 at the time of v3 release. It also makes it easy to search which workflows need to be changed.

Soon we will release nextclade v3. Once nextclade v3 hits bioconda, workflows that rely on v2 syntax will break. To prevent this, this PR makes it explicit that the syntax used is for v2 and that the v2 binary nextclade2 should be used.

This binary is in both the nextstrain-base docker image and in the conda-base managed conda environment.

Users who don't use either will have to add nextclade2 to the path.

Over the next few weeks, we will transition repos to use nextclade3. The reason to add nextclade2 now is so that workflows don't break if they haven't yet transitioned to nextclade3 at the time of v3 release. It also makes it easy to search which workflows need to be changed.
@corneliusroemer corneliusroemer merged commit 5d3a267 into master Jan 15, 2024
4 checks passed
@corneliusroemer corneliusroemer deleted the nextclade2 branch January 15, 2024 23:58
@corneliusroemer
Copy link
Member Author

Merging as we will release tomorrow

@joverlee521
Copy link
Contributor

The ingest pipeline ran fine the last couple days but ran into an error today for the align rule:

[batch] [2024-01-18T08:13:06-08:00] Error: 
[batch] [2024-01-18T08:13:06-08:00]    0: ^[[91mspecified file not found in archive^[[0m
[batch] [2024-01-18T08:13:06-08:00] Location:
[batch] [2024-01-18T08:13:06-08:00]    ^[[35mpackages_rs/nextclade-cli/src/dataset/dataset_download.rs^[[0m:^[[35m65^[[0m
[batch] [2024-01-18T08:13:06-08:00] Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
[batch] [2024-01-18T08:13:06-08:00] Run with RUST_BACKTRACE=full to include source snippets.

It's not clear why this ran fine before, but I think this is due to the nextclade dataset command downloading the V3 dataset?

nextclade dataset get --name MPXV --output-zip {output}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants