Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NotificationDelivery #274

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update NotificationDelivery #274

wants to merge 4 commits into from

Conversation

nounder
Copy link
Contributor

@nounder nounder commented Jan 9, 2025

@nounder nounder self-assigned this Jan 9, 2025
@manan19
Copy link
Contributor

manan19 commented Jan 9, 2025

@nounder need to remove the new field that was added in the previous PR

@nounder
Copy link
Contributor Author

nounder commented Jan 9, 2025

@manan19 Ah, good catch. Done in d0c474a

This PR is based on a commit before the merge and I didn't see it locally. Had to pull from main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manan19 manan19 Awaiting requested review from manan19

@Shreyaschorge Shreyaschorge Awaiting requested review from Shreyaschorge

At least 1 approving review is required to merge this pull request.

Assignees

@nounder nounder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nounder @manan19