Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated kaust profile #824

Merged
merged 23 commits into from
Jan 15, 2025
Merged

Updated kaust profile #824

merged 23 commits into from
Jan 15, 2025

Conversation

husensofteng
Copy link
Contributor

@husensofteng husensofteng commented Jan 7, 2025


name: Updated kaust profile
about: Update the main kaust config and added pipeline specific profiles for rnaseq and mag to overwrite some default limits set by those workflows.

Please follow these steps before submitting your PR:

  • If your PR is a work in progress, include [WIP] in its title
  • Your PR targets the master branch
  • You've included links to relevant issues, if any

Steps for adding a new config profile:

  • Add your custom config file to the conf/ directory
  • Add your documentation file to the docs/ directory
  • Add your custom profile to the nfcore_custom.config file in the top-level directory
  • Add your custom profile to the README.md file in the top-level directory
  • Add your profile name to the profile: scope in .github/workflows/main.yml
  • OPTIONAL: Add your custom profile path and GitHub user name to .github/CODEOWNERS (**/<custom-profile>** @<github-username>)

@husensofteng husensofteng requested review from jfy133 and removed request for jfy133 January 7, 2025 08:43
Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment why tests are failing

You need some more documentation about the pipeline specific configs: https://github.com/nf-core/configs/tree/master/docs/pipeline

And also on the main README of the repo where we list

conf/kaust.config Outdated Show resolved Hide resolved
docs/kaust.md Outdated Show resolved Hide resolved
@husensofteng
Copy link
Contributor Author

See my comment why tests are failing

You need some more documentation about the pipeline specific configs: https://github.com/nf-core/configs/tree/master/docs/pipeline

And also on the main README of the repo where we list

Thanks for the pointer, I have now added the docs.

@husensofteng
Copy link
Contributor Author

@jfy133 thanks for suggestion, now the config is also working after moving the file to a public github repo :)

@jfy133
Copy link
Member

jfy133 commented Jan 14, 2025

You can merge @husensofteng !

@husensofteng husensofteng merged commit 15892ce into nf-core:master Jan 15, 2025
139 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants