Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Important! Template update for nf-core/tools v3.1.2 #569

Merged
merged 8 commits into from
Jan 23, 2025

Conversation

nf-core-bot
Copy link
Member

Version 3.1.2 of nf-core/tools has just been released with updates to the nf-core template. This automated pull-request attempts to apply the relevant updates to this pipeline.

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-3.1.2 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see https://nf-co.re/docs/contributing/sync/.

For more information about this release of nf-core/tools, please see the v3.1.2 release page.

Copy link

github-actions bot commented Jan 23, 2025

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit b8a42de

+| ✅ 278 tests passed       |+
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: conf/igenomes_ignored.config
  • pipeline_todos - TODO string in nextflow.config: Update the field with the details of the contributors to your pipeline. New with Nextflow version 24.10.0

✅ Tests passed:

Run details

  • nf-core/tools version 3.1.2
  • Run at 2025-01-23 11:45:28

Fix is a template change, see nf-core/tools#3416
If your pipeline is affected by this error I think it should be fine to manually apply this patch.
@sofstam sofstam requested a review from jfy133 January 23, 2025 10:16
README.md Outdated
@@ -6,7 +6,8 @@
</h1>

[![GitHub Actions CI Status](https://github.com/nf-core/taxprofiler/actions/workflows/ci.yml/badge.svg)](https://github.com/nf-core/taxprofiler/actions/workflows/ci.yml)
[![GitHub Actions Linting Status](https://github.com/nf-core/taxprofiler/actions/workflows/linting.yml/badge.svg)](https://github.com/nf-core/taxprofiler/actions/workflows/linting.yml)[![AWS CI](https://img.shields.io/badge/CI%20tests-full%20size-FF9900?labelColor=000000&logo=Amazon%20AWS)](https://nf-co.re/taxprofiler/results)[![Cite with Zenodo](http://img.shields.io/badge/DOI-10.5281/zenodo.7728364-1073c8?labelColor=000000)](https://doi.org/10.5281/zenodo.7728364)
[![GitHub Actions Linting Status](https://github.com/nf-core/taxprofiler/actions/workflows/linting.yml/badge.svg)](https://github.com/nf-core/taxprofiler/actions/workflows/linting.yml)[![AWS CI](https://img.shields.io/badge/CI%20tests-full%20size-FF9900?labelColor=000000&logo=Amazon%20AWS)](https://nf-co.re/taxprofiler/results)[![Cite with Zenodo](http://img.shields.io/badge/DOI-10.5281/zenodo.XXXXXXX-1073c8?labelColor=000000)](https://doi.org/10.5281/zenodo.XXXXXXX)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to copy teh Zenodo ID over (currently we wiull have just XXXX)

nextflow.config Outdated Show resolved Hide resolved
@sofstam
Copy link
Collaborator

sofstam commented Jan 23, 2025

@nf-core-bot fix linting

README.md Outdated Show resolved Hide resolved
nextflow.config Outdated Show resolved Hide resolved
@sofstam sofstam requested a review from jfy133 January 23, 2025 12:32
@jfy133
Copy link
Member

jfy133 commented Jan 23, 2025

GTG @sofstam

@sofstam sofstam merged commit 34c5079 into dev Jan 23, 2025
26 checks passed
@sofstam sofstam deleted the nf-core-template-merge-3.1.2 branch January 23, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants