Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced DESFIRE_TRANSCEIVE by a function (TODO n°3) #105

Merged
merged 9 commits into from
Nov 5, 2019
Merged

Replaced DESFIRE_TRANSCEIVE by a function (TODO n°3) #105

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
be5f588
Replaced DESFIRE_TRANSCEIVE by a function (TODO n°3)
broth-itk Jan 26, 2019
3d1c096
Updated comments
broth-itk Jan 26, 2019
facd5b7
Merge branch 'master' into fix_desfire_transceive
broth-itk Jan 26, 2019
e14ae1b
- Added return code checking in functions
broth-itk Feb 3, 2019
0349468
Fixed warnings
broth-itk Feb 5, 2019
e10fe7b
Merge branch 'master' into fix_desfire_transceive
broth-itk Jul 8, 2019
b9df439
Merge branch 'master' into fix_desfire_transceive
darconeous Oct 29, 2019
f620328
Merge branch 'master' into fix_desfire_transceive
darconeous Oct 29, 2019
ea59fa8
fix whitespace
darconeous Nov 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions TODO
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,6 @@
mifare_classic_authenticate() with a NULL key).
[ ] MAD and MifareApplication functions are tied to mifare_clasic_* ones and
some refactoring is required to have a consistent API.
[ ] The DESFIRE_TRANSCEIVE macro should be replaced by a function
DESFIRE_TRANSCEIVE was originaly a macro to enclose a nfc_initiator_trans-
ceive_bytes() call with debug lines. The functions has unexpectedly grown
up and is now between 25 and 100 lines of code (depending of my refactoring
mood). The main drawbacks are poor readability, redundant code in the
binary, debuggers don't cope well with macros, and by design it sucks.
[ ] Refactor examples and have consistent behavior.
Dump to stdout unless -o is specified;
Read from stdin unless a file is specified;
Expand Down
Loading