CP/DP Split: Support basic NGINX OSS provisioning #3114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
bjee19
reviewed
Feb 10, 2025
sjberman
force-pushed
the
chore/provision-nginx
branch
from
15d86bb to
d7f5f58
Compare
bjee19
reviewed
Feb 11, 2025
bjee19
reviewed
Feb 11, 2025
bjee19
reviewed
Feb 11, 2025
bjee19
reviewed
Feb 11, 2025
salonichf5
reviewed
Feb 11, 2025
salonichf5
reviewed
Feb 12, 2025
salonichf5
reviewed
Feb 12, 2025
salonichf5
reviewed
Feb 12, 2025
salonichf5
reviewed
Feb 12, 2025
salonichf5
reviewed
Feb 12, 2025
salonichf5
approved these changes
Feb 13, 2025
sjberman
force-pushed
the
change/control-data-plane-split
branch
from
b1ba80c to
a5c989e
Compare
sjberman
force-pushed
the
chore/provision-nginx
branch
from
1aeca7e to
c2a3425
Compare
This commit updates the control plane to deploy an NGINX data plane when a valid Gateway resource is created. When the Gateway is deleted or becomes invalid, the data plane is removed. The NginxProxy resource has been updated with numerous configuration options related to the k8s deployment and service configs, which the control plane will apply to the NGINX resources when set. The control plane fully owns the NGINX deployment resources, so users who want to change any configuration must do so using the NginxProxy resource. This does not yet support NGINX Plus or NGINX debug mode. Those will be added in followup pull requests. This also adds some basic daemonset fields, but does not yet support deploying a daemosnet. That will also be added soon.
sjberman
force-pushed
the
chore/provision-nginx
branch
from
c2a3425 to
83c4566
Compare
sjberman
merged commit b884670
into
nginx:change/control-data-plane-split
20 of 21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the control plane to deploy an NGINX data plane when a valid Gateway resource is created. When the Gateway is deleted or becomes invalid, the data plane is removed. The NginxProxy resource has been updated with numerous configuration options related to the k8s deployment and service configs, which the control plane will apply to the NGINX resources when set. The control plane fully owns the NGINX deployment resources, so users who want to change any configuration must do so using the NginxProxy resource.
This does not yet support NGINX Plus or NGINX debug mode. Those will be added in followup pull requests. This also adds some basic daemonset fields, but does not yet support deploying a daemosnet. That will also be added soon.
Testing: Verified the following for OSS