Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install 'cryptography' using 'pip' Instead of Using System's Package Manager #596

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

jswongF5
Copy link
Contributor

@jswongF5 jswongF5 commented Mar 14, 2023

Proposed changes

The cryptography package was installed using the OS's repo package manager. This PR will change from using the system's package manager to pip.

This is to resolve an error when running this role using Amazon Linux 2 (AL2). The python interpreter uses python2 in container tests but python3 on AL2 deployed in AWS. This role tries to install python3-cryptography which does not exists.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have added Molecule tests that prove my fix is effective or that my feature works
  • I have checked that any relevant Molecule tests pass after adding my changes
  • I have updated any relevant documentation (defaults/main/*.yml, README.md and CHANGELOG.md)

@jswongF5 jswongF5 requested a review from alessfg as a code owner March 14, 2023 05:15
@alessfg alessfg added the enhancement Enhance/improve an existing feature label Apr 4, 2023
@alessfg alessfg force-pushed the main branch 4 times, most recently from 0e3be34 to 84126a7 Compare July 6, 2023 13:06
@alessfg alessfg force-pushed the main branch 5 times, most recently from ece31b1 to 8d41705 Compare July 29, 2024 12:00
@alessfg alessfg force-pushed the main branch 4 times, most recently from 6961947 to 8bf1b69 Compare October 9, 2024 15:23
@alessfg alessfg force-pushed the main branch 3 times, most recently from 1c4beea to 2e7f05b Compare October 14, 2024 20:36
@alessfg alessfg force-pushed the main branch 2 times, most recently from f1a5b9a to cab3c97 Compare October 15, 2024 23:05
@alessfg alessfg force-pushed the main branch 25 times, most recently from 2b3ef05 to 0a9d339 Compare November 30, 2024 01:07
Copy link

🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree:


I have hereby read the F5 CLA and agree to its terms


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance/improve an existing feature
Projects
Development

Successfully merging this pull request may close these issues.

2 participants