-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a new example for oauth that uses webview #147
Conversation
This should provide another solution for #93 |
Nice, thanks. Will ask a colleague to review in the upcoming days. For the record, we are currently working on adding support for native authentication with hasura-auth so there will be no need of using a webview for apple/google sign in on ios/android. |
Thank you @totzk9 for your contribution! 🙌 I encountered an issue while trying to run this on an iOS simulator. It seems there might be a problem with the url_launcher dependency. Here’s the error I get:
|
I think we can close this PR since Nhost now supports idTokens for OAuth |
Don't you need the webview for, let's say "Sign in with Apple" on android or "sign in with Google" on iOS"? Assuming you want to provide parity between iOS/Android applications. |
That does makes sense. Let me look on the issue mentioned above. PS. Theres a plugin for iOS that can call native oauth for Google. |
- alignment of buttons - replace deprecated params and types
@totzk9 is this one ready? not sure if you are still working on it. Happy to take a look and merge if ready |
Hi there, yes this is finished |
I am not entirely sure why but the CI seems quite broken :S |
I'll see what I can do |
…/nhost-dart into add_oauth_webview_example
@dbarrosop pushed some changes and tested from my fork. You can run it again now |
Thanks a lot, your contributions are highly appreciated. |
This PR provides an example using webview.
The previous example wont work because OAuth providers like Google, Facebook and Apple doesn't acknowledge
launchUrl
as secure enough (It does work for flutter_web tho).