Fix for Select page object clickOption method. #2527
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
When refactoring some tests for the notebook selector in SLE, I ran into some issues when trying to use the
clickOption
method on the page object for a dynamic filtering scenario. In this specific scenario, using the index-based click method was needed overclickOptionWithDisplayText
, as the use-case had two options with the same display text (under different groups).👩💻 Implementation
Essentially the issue is that it is unreliable to use the
options
member on theSelect
to query for the options that are visible, specifically when doing manual filtering (where it is expected that option elements are being removed from the DOM). Instead, it's more accurate to simply do aquerySelectorAll
for the options, and then filter on the same expected state.🧪 Testing
Wrote some unit tests against the
clickOption
method on the page object.✅ Checklist