Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't emit eslint warnings in PR build #59

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

mure
Copy link
Collaborator

@mure mure commented Apr 25, 2024

Pull Request

🤨 Rationale

eslint is producing some warnings because of deprecations. We should fix these at some point, but until then it's cluttering up the PR review because of a new GitHub feature that can't be disabled 😐

image

👩‍💻 Implementation

  • Pass the --quiet flag to eslint in the PR workflow

🧪 Testing

  • Ran command locally and verified it does what we expect

✅ Checklist

@mure mure requested a review from cameronwaterman as a code owner April 25, 2024 22:26
@mure mure enabled auto-merge (squash) April 25, 2024 22:35
@mure mure merged commit cb3c523 into main Apr 29, 2024
1 check passed
@mure
Copy link
Collaborator Author

mure commented May 7, 2024

🎉 This PR is included in version 3.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@mure mure added the released label May 7, 2024
@mure mure deleted the silence-eslint-warnings branch October 3, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants