-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tag): visualize history of multiple tags #60
Conversation
update descriptions minor changes
add workspace column for current query
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this out locally and the data isn't looking like how I would expect. Even when the timestamps match up, the columns alternate missing values, which seems to create gaps in the chart.
It gets weirder when your tags aren't updating at the same frequency.
There's not any way to guarantee that the tag history returned by the query will have uniform timestamps, so I think what we should do is return each tag in a separate data frame/series (the second example in these docs).
This is the first time we've needed to do this in a plugin, so we'll need to make the runQuery
method support returning a list of data frames: DataFrameDTO[]
One advantage of this approach is that we can continue to have the Properties toggle for the history query instead of hiding it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving to "Request changes" in order to review open conversations
@markacamps @TigranVardanyan - Carson left a comment yesterday related to the return type of the |
We won't need to do this if we're only returning one data frame, as was the outcome of the other conversation |
@mure is this clear to merge? |
Done |
## [3.13.0](v3.12.1...v3.13.0) (2024-09-11) ### Features * **tag:** visualize history of multiple tags ([#60](#60)) ([5826522](5826522))
π This PR is included in version 3.13.0 π The release is available on:
Your semantic-release bot π¦π |
Pull Request
π€¨ Rationale
The "history" query type currently visualizes data only for the first matched tag. Need to visualize data from all matched tags.
π©βπ» Implementation
Implemented functions to retrieve tag history in chunks and merge responses into a single dataframe. Since it is impossible to have properties of multiple tags in one dataframe with those historical values, "Properties" option in now available only for query type "Current".
π§ͺ Testing
Added a test to check if the history of multiple tags is processed correctly. Added a test to ensure the properties switch button is hidden when the query type is "History".
β Checklist