feat(asset-calibration): added systems as dropdown values for location #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saradei-ni
requested review from
CiprianAnton,
kkerezsi,
mure and
cameronwaterman
as code owners
saradei-ni
force-pushed
the
users/saradei/2866342
branch
2 times, most recently
from
d9d7b84 to
09950d0
Compare
|
@mure Can you please take a look at this one as well? We needed some small updates in core. |
kkerezsi
approved these changes
Oct 4, 2024
src/datasources/asset-calibration/components/AssetCalibrationQueryBuilder.tsx
Outdated
Show resolved
Hide resolved
mure
approved these changes
Oct 4, 2024
saradei-ni
force-pushed
the
users/saradei/2866342
branch
from
09950d0 to
565eb12
Compare
saradei-ni
force-pushed
the
users/saradei/2866342
branch
from
565eb12 to
849d57d
Compare
mure
pushed a commit
that referenced
this pull request
Oct 7, 2024
## [3.18.0](v3.17.0...v3.18.0) (2024-10-07) ### Features * **asset-calibration:** added systems as dropdown values for location ([#76](#76)) ([5f74d39](5f74d39))
|
🎉 This PR is included in version 3.18.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
User Story 2798210: [UI][Grafana] Add support for filters on the Grafana plugin
👩💻 Implementation
Used fetched systems, passed them to query builder in order to update the location datasource.
🧪 Testing
Added and adapted unit tests.
The layout has been updated to reflect the requirements.
✅ Checklist