forked from madprime/python-gedcom
-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parsers #53
Open
nickreynke
wants to merge
32
commits into
develop
Choose a base branch
from
cdhorn-add-parsers
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add parsers #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nickreynke
commented
Aug 7, 2020
Repository owner
deleted a comment
Aug 8, 2020
Repository owner
deleted a comment
Aug 8, 2020
Repository owner
deleted a comment
Aug 8, 2020
Repository owner
deleted a comment
Aug 8, 2020
Repository owner
deleted a comment
Aug 8, 2020
Repository owner
deleted a comment
Aug 8, 2020
Repository owner
deleted a comment
Aug 8, 2020
0c2af1f
to
a3ebc2b
Compare
Repository owner
deleted a comment
Aug 8, 2020
Repository owner
deleted a comment
Aug 10, 2020
4f23fca
to
0a2c522
Compare
Removed FileElement as duplicates role of ObjectElement. Added Source, Repository, Note, Header, Submission, and Submitter elements to handle all the defined record types in the standard. Add subparsers for all of the substructures defined in the standard. Added get_record method to all record elements to parse the full record structure and return it as a dictionary. Before processing file added encoding check to identify type. If Python Ansel module is installed use it so can now decode Ansel Gedcoms. Verify encoding found matches encoding claimed. Get version number. Validate if 5.5.5 and if so reject it as that standard requires as no strict 5.5.5 reader exists yet. Added standards.py with references to the different standards and use where needed. Added Reader object to wrap the Parser and provide get_records_by_type and get_all_records methods.
0a2c522
to
5c76b36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PR in favor of original PR #50 by @cdhorn, because of conflicts with the latest version in the
develop
branch.Todo list:
subparsers
list (prefixed withparse_
to further clarify that the methods parse something)element
module toelements
(see https://softwareengineering.stackexchange.com/a/75929)Original post: