Implement More CPU Percentage Color Indicators #2995 #3035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o load waning and carful thresholds.
|
Note: Implementation should also be done in the WebUI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please describe the goal of this pull request.
This PR is adding a new option to the config file
And then performs and equality check in
glances/plugins/processlist/__init__.pyto see if there is any process with the same username and displays it with aCRITICALdecoration.This PR also digs into the CPU percentage colour indicators and found some issues with the
get_alert()function. There seems to be an issue with all non critical limits. Any warning or careful limit is not being used correctly inget_alert(). As I result I created a new function to bypassget_alert()for now so that #2995 is fully fixed and implemented.I also had some issues with the linter and generating docs so I am sorry those parts are a little neglected in this PR.
Resume