-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the ability to trigger the calculator from the food tab #1106
Conversation
…et percentage values to zero to not include in carb counts.
code quality is very good. What I'm not sure about is that fat and protein is usually treated as eCarbs and not accounted into a bolus @AdrianLxM |
and for easy usability we should consider adding # of portions next to calc icon |
I do like the idea of handling fat/protein but I think we should discuss it a bit more into detail how we should handle it. I also like the idea of having the calculator directly accessible. 👍 |
The thought for the calculator there was, for snacks rather than for meals, where you can quickly bolus. I.e. bolus for a banana or protein bar are you head out the door in the morning. So wanted to keep it quick and simple. Then to build a more robust meal process where you can add foods/portions/bolus/ecarbs/etc. For a meal. I could add another preference to allow the user to choose whether or not to include fat/protein in the calculator shortcut and have it default to false. Then users can choose to turn it on. Otherwise, I can just split that part out and can discuss further. |
The caveat I see with this calculation of fat/protein is, that it would re-define It would work if we define the I fear that in reality people will test their factors with say toast with a bit of cream cheese which would mean their I personally therefore calculate with "excess fat/protein". So fat/protein exceeding my standard mixture. I do have two proposals up for discussion - maybe there are better solutions though.
To me 2) would feel like a bad workaround though as it wouldn't scale for higher amounts of fat. On the other hand, if people would go with a pure carb factor they would need to add fat/protein always - even with their default mixture. So I'm leaning towards 1). |
If you have mostly fat/protein, a direct bolus might be "too fast". If there still is a larger amount of carbs it is fine in my experience to add it directly to the bolus. Even modern insulins have quite some "rat's tail" that would cover the slower food parts. In energy (kCal) I don't use eCarbs up until 2:1 (fat/protein : carbs). |
@erobinson are you in our discord channel? Can we do some brainstorming there? |
Will do another PR with just the calculator shortcut & w/o the fat/protein included in the carb count. |
Added the ability to bring up the bolus calculator from the food tab. This would allow users to quickly bolus for frequently consumed foods/meals. Working on making a more robust meal calculator where you can add foods & portions, etc. Wanted to create an initial PR for the small changes to get feedback and add initial enhancements.
#1105