Latest changes in GCP #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Clean up eventarc handwritten tests * update indentation
…google_identity_platform_config. (#8559) Co-authored-by: Shuya Ma <[email protected]>
* Apply new labels model to more resources (part 1) * Handle labels field inside flatten object * Fix the tests for datasource * Fix typo * Fix typo
* Add Firestore deletion protection * Reformat * Add test for updating delete_protection_state * Make deleteProtectionState skip auto-generated tests * Add a dedicated example for delete protection
…ret_version` resource import function (#8923)
* updated to ONLY_SCALE_OUT * change the data type to string --------- Co-authored-by: Edward Sun <[email protected]>
* Add Network and Subnet resources for edgenetwork * Fix lint * Added labels field to acceptance tests; Removed send_empty_value:false from vlan_id field in Subnet * Skip edgenetwork acceptance tests
* Apply new labels model to more resources (part 2) * Apply new labels model to more resources (part 3) * Fix unit test
* Apply provider default labels to handwritten resources * Add terraform_labels and effective_labels to doc * New fun SetLabels instead of FlattenLabels * Add comment for func SetLabels
…8943) * Uncomment test cases for unknown values * Update test case names * Update unknown value test for `project`, make it pass * Update unknown value test for `access_token`, make `access_token` and `credentials` tests pass * Update unknown value tests for `region` and `zone`, make those tests pass * Update unknown value tests for `user_project_override`, make that test pass * Update unknown value test for `impersonate_service_account`, make that test pass * Update unknown value tests for `request_reason` and `request_timeout`, make those tests pass * Make unknown batching.send_after and batching.enable_batching values be set to same defaults as if they were null, update test * Update code to handle when the whole batching block is Unknown * Update the test function for `batching` unit tests to navigate how `GetBatchingConfig` is used by the code * Update code to handle null/unknown Scopes and ImpersonateServiceAccountDelegates values * Improve `impersonate_service_account_delegates` tests for unknown values * Add missing null test case for `batching` field * Add non-VCR acceptance test to assert handling of unknown values in provider config Only testing `credentials` currently.
#8971) * Replace InstanceInfo call with Instances call for regional reliability * Handle unavailable error when no overlap * Handle unavailable error when no overlap * Add tests * Add tests * Add tests * Add tests
* Added support for project-level custom modules Related to b/296259216 * gofmt * Added client-side validation of display_name * Fixed expressions in update test * Added mutex
* Reveal Triggerer to GA. * Update resource_composer_environment_test.go.erb Update test to reflect that now we have 1cpu limit on Triggerer. * Upgrade go api version. * Resolve conflicts. * Update Gemfile.lock * Update Gemfile.lock
* Make service account name non-static * Update WorkflowConfig.yaml
* Updatd default provider version to 5.0.0 * Re-enabled tgc integration tests * Corrected tgc integration test entrypoint * Set additional env vars during terraform runs * Added project data into tests that now have a project known due to provider defaults work * Added network_firewall_policy_enforcement_order default * Added some more new defaults to testdata * Corrected expected results for example_compute_instance * Fixed storage bucket without project tests * Corrected WithoutDefaultProject test list
* Remove IP validation for host of on-premise instance In admin API, we don't have validation for host of on-premise instances. Host can take the value of IP address or DNS address. As of now it is validating that host contain the IP address in terraform, in order to be consistent with admin API and accept DNS address as well, removing the validation function for host. * Update the description of the host field
* support to create instance with ssl mode and require connectors, with acceptance tests * removed client_connection_config in basic instance example, and cleaned up the code a little bit * attempts to set the default ssl mode in the custom code * able to set default value during instance creation and addressing some comments * trying to fix updating ssl mode * fixed updating the instance with ssl mode * cleaning up code and fixing acceptance tests * Fixing spacing issues in instance.yaml * fixing spacing issues again in instance.yaml * fixing formatting in unit test * fixing the acceptance tests for other alloydb resources by explicitly adding the clientconnectionconfig * fixing spacing and removing commented out imports * commenting out createInstanceWithMandatoryFields and createPrimaryAndReadPoolInstance tests because they're failing due to an unrelated service networking issue * fix tests failing due to missing client_connection_config * removing service networking resources from tests since there's a bug in service networking * fix breaking change that causes a permadiff in terraform on update * uncomment out the TestAccAlloydbInstance_createPrimaryAndReadPoolInstance and TestAccAlloydbInstance_createInstanceWithMandatoryFields tests * remove private_ip_alloc from client connection config tests * use BootstrapSharedServiceNetworkingConnection in tests instead of BootstrapSharedTestNetwork in tests * add back in custom code * remove commented out code * fix formatting * match network name to be the same format as the other acceptance tests in the file * change network names in test * remove custom code and update e2e test * remove default test case and add more update steps to update test
…google/services/` (#9218)
* promote gkeonprem resources to GA * fix update test
…top-level field (#9199) * Deprectate time_partitioning.require_partitioning_filter and add new top-level field * Use deprecated require_partition_filter field in one of the tests
* Adding support for listing networks in a Google Cloud project through a new data source * Updating documentation for data source. Removing print from data source.
Co-authored-by: Riley Karson <[email protected]>
#9253) * ForceNew on labels field when the dataflow job has type JOB_TYPE_BATCH * Handle the case that no update is needed
Co-authored-by: sunchengxuanivy <[email protected]>
* Migrate generate comment to go * Capitalize all test error messages * Move exec to separate package, refactor functions
…` resource (#9217) * Add `additional_group_keys` attribute to `google_cloud_identity_group` resource * Update acceptance test to check for attribute * Fix test check * Add `output: true` to nested properties in output field
* Add labels develop guide * Move labels doc to Best Practices
…un (#9236) * Update build step so tests only run if there are tests to run * Add guard against empty folders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note Template for Downstream PRs (will be copied)