Adding Bp and BPA resources with examples to backupdr product #18
Conversation
|
|
||
| --- !ruby/object:Api::Resource | ||
| name: 'BackupPlan' | ||
| # Remove this towards GA. b/371938375 |
There was a problem hiding this comment.
This is probably not needed anymore
| autogen_async: true | ||
| timeouts: | ||
| insert_minutes: 20 | ||
| delete_minutes: 20 |
There was a problem hiding this comment.
Are these standard API timeouts?
There was a problem hiding this comment.
Updated standard tineouts,
| examples: | ||
| - min_version: beta | ||
| name: 'backup_dr_backup_plan' | ||
| primary_resource_id: 'my-backup-plan' |
There was a problem hiding this comment.
No, primary_resource_id is tf resource name while name is example name
| timeouts: | ||
| insert_minutes: 20 | ||
| delete_minutes: 20 | ||
| examples: |
There was a problem hiding this comment.
Could you move examples to the bottom of the file?
There was a problem hiding this comment.
AS per convention they stay at top. Would you still want me to move it to bottom?
| timeouts: | ||
| insert_minutes: 20 | ||
| delete_minutes: 20 | ||
| examples: |
There was a problem hiding this comment.
Move this to the bottom of the file
There was a problem hiding this comment.
This is as per convention
| start_hour_of_day: 5 | ||
| end_hour_of_day: 20 | ||
| backup_plan_association_name: 'bpa1' | ||
| resource_name: 'projects/gcp-project/locations/us-central1/{instance_id}' |
There was a problem hiding this comment.
This list seems to show the output_only fields as well. You might want to revisit this.
There was a problem hiding this comment.
fixed by adding field values in example file onkly
Release Note Template for Downstream PRs (will be copied)